fix: harden article rich content rendering (#36) (thanks @crcatala)

src/lib/twitter-client-search.ts

@@ -4,6 +4,8 @@ import { buildSearchFeatures } from './twitter-client-features.js';
 import type { SearchResult, TweetData } from './twitter-client-types.js';
 import { extractCursorFromInstructions, parseTweetsFromInstructions } from './twitter-client-utils.js';
 
+const RAW_QUERY_MISSING_REGEX = /must be defined/i;
+
 /** Options for search methods */
 export interface SearchFetchOptions {
   /** Include raw GraphQL response in `_raw` field */
@@ -24,7 +26,7 @@ function isQueryIdMismatch(payload: string): boolean {
         if (error?.extensions?.code === 'GRAPHQL_VALIDATION_FAILED') {
           return true;
         }
-        if (error?.path?.includes('rawQuery') && /must be defined/i.test(error.message ?? '')) {
+        if (error?.path?.includes('rawQuery') && RAW_QUERY_MISSING_REGEX.test(error.message ?? '')) {
           return true;
         }
         return false;
@@ -143,7 +145,9 @@ export function withSearch<TBase extends AbstractConstructor<TwitterClientBase>>
             };
 
             if (data.errors && data.errors.length > 0) {
-              const shouldRefreshQueryIds = data.errors.some((error) => error?.extensions?.code === 'GRAPHQL_VALIDATION_FAILED');
+              const shouldRefreshQueryIds = data.errors.some(
+                (error) => error?.extensions?.code === 'GRAPHQL_VALIDATION_FAILED',
+              );
               return {
                 success: false as const,
                 error: data.errors.map((e) => e.message).join(', '),

src/lib/twitter-client-types.ts

@@ -137,17 +137,26 @@ export type GraphqlTweetResult = {
             type: string;
             text: string;
             data?: Record<string, unknown>;
-            entityRanges: Array<{ key: number; offset: number; length: number }>;
-            inlineStyleRanges: Array<{ offset: number; length: number; style: string }>;
-          }>;
-          entityMap: Array<{
-            key: string;
-            value: {
-              type: string;
-              mutability: string;
-              data: Record<string, unknown>;
-            };
+            entityRanges?: Array<{ key: number; offset: number; length: number }>;
+            inlineStyleRanges?: Array<{ offset: number; length: number; style: string }>;
           }>;
+          entityMap?:
+            | Array<{
+                key: string;
+                value: {
+                  type: string;
+                  mutability: string;
+                  data: Record<string, unknown>;
+                };
+              }>
+            | Record<
+                string,
+                {
+                  type: string;
+                  mutability: string;
+                  data: Record<string, unknown>;
+                }
+              >;
         };
       };
     };

src/lib/twitter-client-utils.ts

@@ -92,8 +92,8 @@ interface ContentBlock {
   data?: {
     mentions?: Array<{ fromIndex: number; toIndex: number; text: string }>;
   };
-  entityRanges: EntityRange[];
-  inlineStyleRanges: InlineStyleRange[];
+  entityRanges?: EntityRange[];
+  inlineStyleRanges?: InlineStyleRange[];
 }
 
 /** Entity data for different entity types */
@@ -116,7 +116,7 @@ interface EntityMapEntry {
 /** Draft.js content state structure */
 interface ContentState {
   blocks: ContentBlock[];
-  entityMap: EntityMapEntry[];
+  entityMap?: Array<EntityMapEntry> | Record<string, EntityValue>;
 }
 
 /**
@@ -128,12 +128,22 @@ export function renderContentState(contentState: ContentState | undefined): stri
     return undefined;
   }
 
-  // Build entity lookup map from array format
+  // Build entity lookup map from array/object formats
   const entityMap = new Map<number, EntityValue>();
-  for (const entry of contentState.entityMap ?? []) {
-    const key = Number.parseInt(entry.key, 10);
-    if (!Number.isNaN(key)) {
-      entityMap.set(key, entry.value);
+  const rawEntityMap = contentState.entityMap ?? [];
+  if (Array.isArray(rawEntityMap)) {
+    for (const entry of rawEntityMap) {
+      const key = Number.parseInt(entry.key, 10);
+      if (!Number.isNaN(key)) {
+        entityMap.set(key, entry.value);
+      }
+    }
+  } else {
+    for (const [key, value] of Object.entries(rawEntityMap)) {
+      const keyNumber = Number.parseInt(key, 10);
+      if (!Number.isNaN(keyNumber)) {
+        entityMap.set(keyNumber, value);
+      }
     }
   }
 
@@ -239,7 +249,7 @@ function renderBlockText(block: ContentBlock, entityMap: Map<number, EntityValue
 
   // Handle LINK entities by appending URL in markdown format
   // Process in reverse order to not mess up offsets
-  const linkRanges = block.entityRanges
+  const linkRanges = (block.entityRanges ?? [])
     .filter((range) => {
       const entity = entityMap.get(range.key);
       return entity?.type === 'LINK' && entity.data.url;
@@ -262,11 +272,12 @@ function renderBlockText(block: ContentBlock, entityMap: Map<number, EntityValue
  * Renders an atomic block by looking up its entity and returning appropriate content.
  */
 function renderAtomicBlock(block: ContentBlock, entityMap: Map<number, EntityValue>): string | undefined {
-  if (block.entityRanges.length === 0) {
+  const entityRanges = block.entityRanges ?? [];
+  if (entityRanges.length === 0) {
     return undefined;
   }
 
-  const entityKey = block.entityRanges[0].key;
+  const entityKey = entityRanges[0].key;
   const entity = entityMap.get(entityKey);
 
   if (!entity) {
@@ -332,8 +343,17 @@ export function extractArticleText(result: GraphqlTweetResult | undefined): stri
   const richBody = renderContentState(contentState);
   if (richBody) {
     // Rich content found - prepend title if not already included
-    if (title && !richBody.startsWith(title)) {
-      return `${title}\n\n${richBody}`;
+    if (title) {
+      const normalizedTitle = title.trim();
+      const trimmedBody = richBody.trimStart();
+      const headingMatches = [`# ${normalizedTitle}`, `## ${normalizedTitle}`, `### ${normalizedTitle}`];
+      const hasTitle =
+        trimmedBody === normalizedTitle ||
+        trimmedBody.startsWith(`${normalizedTitle}\n`) ||
+        headingMatches.some((heading) => trimmedBody.startsWith(heading));
+      if (!hasTitle) {
+        return `${title}\n\n${richBody}`;
+      }
     }
     return richBody;
   }