bird/tests/twitter-client-coverage.news.test.ts

import { afterEach, describe, expect, it, vi } from 'vitest';
import { TwitterClient } from '../src/lib/twitter-client.js';

const testRelayBaseUrl = 'https://relay.example';

type ResponseLike = {
  ok: boolean;
  status: number;
  json: () => Promise<unknown>;
  text: () => Promise<string>;
};

const makeResponse = (overrides: Partial<ResponseLike> = {}): ResponseLike => ({
  ok: true,
  status: 200,
  json: async (): Promise<unknown> => ({}),
  text: async (): Promise<string> => '',
  ...overrides,
});

// Helper to create GenericTimelineById response structure
const makeTimelineResponse = (items: unknown[]) => ({
  data: {
    timeline: {
      timeline: {
        instructions: [
          {
            type: 'TimelineAddEntries',
            entries: items.map((item, index) => ({
              entryId: `test-entry-${index}`,
              content: {
                items: [
                  {
                    item: {
                      itemContent: item,
                    },
                  },
                ],
              },
            })),
          },
        ],
      },
    },
  },
});

const makeTimelineResponseWithInstruction = (type: string, entries: unknown[]) => ({
  data: {
    timeline: {
      timeline: {
        instructions: [
          {
            type,
            entries,
          },
        ],
      },
    },
  },
});

describe('TwitterClient news API coverage', () => {
  const originalFetch = global.fetch;

  afterEach(() => {
    global.fetch = originalFetch;
    vi.restoreAllMocks();
  });

  describe('getNews', () => {
    it('returns news items from timeline tabs', async () => {
      // Mock multiple tab requests (forYou, news, sports, entertainment)
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponse([
                {
                  is_ai_trend: true,
                  name: 'AI Breakthrough in Machine Learning',
                  social_context: {
                    text: 'AI · 2h ago · 15.5K posts',
                  },
                  trend_url: {
                    url: 'https://x.com/hashtag/AI',
                  },
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(1);

      expect(result.success).toBe(true);
      expect(result.items).toBeDefined();
      expect(result.items?.length).toBe(1);
      expect(result.items?.[0].headline).toBe('AI Breakthrough in Machine Learning');
      expect(result.items?.[0].category).toBe('AI · AI');
      expect(result.items?.[0].timeAgo).toBe('2h ago');
      expect(result.items?.[0].postCount).toBe(15500);
      expect(result.items?.[0].url).toBe('https://x.com/hashtag/AI');
    });

    it('includes raw item content when includeRaw is true', async () => {
      const itemContent = {
        is_ai_trend: true,
        name: 'AI News',
        social_context: { text: 'AI · 1h ago · 1.2K posts' },
      };
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(makeResponse({ json: async () => makeTimelineResponse([itemContent]) }))
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(1, { includeRaw: true });

      expect(result.success).toBe(true);
      expect(result.items?.[0]._raw).toEqual(itemContent);
    });

    it('filters to AI-only items when aiOnly is true', async () => {
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponse([
                {
                  is_ai_trend: true,
                  name: 'AI News',
                },
                {
                  is_ai_trend: false,
                  name: 'Regular News',
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(10, { aiOnly: true });

      expect(result.success).toBe(true);
      expect(result.items?.length).toBe(1);
      expect(result.items?.[0].headline).toBe('AI News');
    });

    it('fetches only selected tabs', async () => {
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponse([
                {
                  is_ai_trend: true,
                  name: 'News 1',
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(1, { tabs: ['news'] });

      expect(result.success).toBe(true);
      expect(mockFetch).toHaveBeenCalledTimes(1);
    });

    it('returns error for non-ok responses', async () => {
      // Mock all 4 default tabs (forYou, news, sports, entertainment) to return HTTP 500
      const mockFetch = vi
        .fn()
        .mockResolvedValue(makeResponse({ ok: false, status: 500, text: async () => 'Server error' }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(10);

      expect(result.success).toBe(false);
      expect(result.error).toContain('No news items found');
    });

    it('returns error when API returns errors', async () => {
      // Mock all 4 default tabs to return API errors
      const mockFetch = vi.fn().mockResolvedValue(
        makeResponse({
          json: async () => ({
            errors: [{ message: 'Rate limited' }, { message: 'Too many requests' }],
          }),
        }),
      );

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(10);

      expect(result.success).toBe(false);
      expect(result.error).toContain('No news items found');
    });

    it('returns error when no news items found', async () => {
      const mockFetch = vi.fn().mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(10);

      expect(result.success).toBe(false);
      expect(result.error).toContain('No news items found');
    });

    it('deduplicates headlines across tabs', async () => {
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponse([
                {
                  is_ai_trend: true,
                  name: 'Duplicate Headline',
                },
              ]),
          }),
        )
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponse([
                {
                  is_ai_trend: true,
                  name: 'Duplicate Headline',
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(10);

      expect(result.success).toBe(true);
      expect(result.items?.length).toBe(1);
      expect(result.items?.[0].headline).toBe('Duplicate Headline');
    });

    it('respects count parameter', async () => {
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponse([
                {
                  is_ai_trend: true,
                  name: 'News 1',
                },
                {
                  is_ai_trend: true,
                  name: 'News 2',
                },
                {
                  is_ai_trend: true,
                  name: 'News 3',
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(2);

      expect(result.success).toBe(true);
      expect(result.items?.length).toBe(2);
    });

    it('parses entries from non-TimelineAddEntries instructions', async () => {
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponseWithInstruction('TimelineReplaceEntry', [
                {
                  entryId: 'replace-entry-1',
                  content: {
                    itemContent: {
                      is_ai_trend: true,
                      name: 'Replacement headline',
                    },
                  },
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(1);

      expect(result.success).toBe(true);
      expect(result.items?.[0].headline).toBe('Replacement headline');
    });

    it('assigns unique ids for module entries', async () => {
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponseWithInstruction('TimelineAddEntries', [
                {
                  entryId: 'module-entry',
                  content: {
                    items: [
                      {
                        item: { itemContent: { is_ai_trend: true, name: 'Headline A' } },
                      },
                      {
                        item: { itemContent: { is_ai_trend: true, name: 'Headline B' } },
                      },
                    ],
                  },
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(2);

      expect(result.success).toBe(true);
      const ids = result.items?.map((item) => item.id) ?? [];
      expect(new Set(ids).size).toBe(ids.length);
    });

    it('uses trend urls as ids when available', async () => {
      const mockFetch = vi
        .fn()
        .mockResolvedValueOnce(
          makeResponse({
            json: async () =>
              makeTimelineResponse([
                {
                  is_ai_trend: true,
                  name: 'Headline A',
                  trend_url: { url: 'https://x.com/hashtag/A' },
                },
              ]),
          }),
        )
        .mockResolvedValue(makeResponse({ json: async () => makeTimelineResponse([]) }));

      global.fetch = mockFetch as unknown as typeof fetch;

      const client = new TwitterClient({ relayBaseUrl: testRelayBaseUrl });
      const result = await client.getNews(1);

      expect(result.success).toBe(true);
      expect(result.items?.[0].id).toBe('https://x.com/hashtag/A');
    });
  });
});